Provide more color in filter registration methods #3036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few years ago we had repeated user confusion dealing with the `Filter` methods and exactly how they differ. Here we try to add a bit more color in several ways as suggested by users in a few places - listing examples of why the methods are used as well as ensuring its clearly communicated that not all parameters need be used. Fixes lightningdevkit#1069
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
==========================================
- Coverage 89.85% 89.84% -0.01%
==========================================
Files 116 116
Lines 96237 96237
Branches 96237 96237
==========================================
- Hits 86471 86464 -7
- Misses 7206 7210 +4
- Partials 2560 2563 +3 ☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
May 14, 2024
|
Looks like good clarifications + it's just docs so gonna merge. |
valentinewallace
merged commit 1237abf
into
lightningdevkit:main
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago we had repeated user confusion dealing with the
Filtermethods and exactly how they differ. Here we try to add a bit more color in several ways as suggested by users in a few places - listing examples of why the methods are used as well as ensuring its clearly communicated that not all parameters need be used.Fixes #1069
Replaces #1395